clintropolis commented on code in PR #16985:
URL: https://github.com/apache/druid/pull/16985#discussion_r1749750883
##########
processing/src/main/java/org/apache/druid/segment/Segment.java:
##########
@@ -64,25 +73,36 @@ public interface Segment extends Closeable
*
* @return instance of clazz, or null if the interface is not supported by
this segment
*
- * @see StorageAdapter storage adapter for queries. Never null.
+ * @see CursorFactory to make cursors to run queries
Review Comment:
yea, though like, in the same way it was true for `StorageAdapter`. It could
actually be null in practice because we got the storage adapter through
`ReferenceCountingSegment`, which returns `null` for a lot of its methods if
the backing segment has been closed due to being dropped, so the javadoc was
kind of lies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
