Akshat-Jain commented on code in PR #16971:
URL: https://github.com/apache/druid/pull/16971#discussion_r1740513095
##########
sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java:
##########
@@ -325,16 +326,20 @@ private static List<Object[]> parseResults(RowSignature
rs, List<String[]> resul
} else {
switch (type.getType()) {
case STRING:
Review Comment:
@cryptoe Makes sense, have moved the `case ARRAY` logic to `parseElement()`
method itself as suggested.
I think it would require some more work to make it work for nested arrays
though, as that would need a `case COMPLEX` logic. But I think we can do that
in future when/if we need to, as it's outside the intended scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
