techdocsmith commented on code in PR #17031: URL: https://github.com/apache/druid/pull/17031#discussion_r1752964673
########## docs/development/extensions-core/mysql.md: ########## @@ -25,41 +25,58 @@ title: "MySQL Metadata Store" To use this Apache Druid extension, [include](../../configuration/extensions.md#loading-extensions) `mysql-metadata-storage` in the extensions load list. -:::info - The MySQL extension requires the MySQL Connector/J library or MariaDB Connector/J library, neither of which are included in the Druid distribution. - Refer to the following section for instructions on how to install this library. -::: +The MySQL extension lets you use MySQL as a metadata store or ingest from a MySQL database. Review Comment: ```suggestion With the MySQL extension, you can use MySQL as a metadata store or ingest from a MySQL database. ``` ########## docs/development/extensions-core/druid-lookups.md: ########## @@ -33,7 +33,7 @@ To use this Apache Druid extension, [include](../../configuration/extensions.md# :::info If using JDBC, you will need to add your database's client JAR files to the extension's directory. Review Comment: ```suggestion To use JDBC, you must add your database client JAR files to the extension's directory. ``` nit: avoid future tense ########## docs/development/extensions-core/postgresql.md: ########## @@ -25,7 +25,9 @@ title: "PostgreSQL Metadata Store" To use this Apache Druid extension, [include](../../configuration/extensions.md#loading-extensions) `postgresql-metadata-storage` in the extensions load list. -## Setting up PostgreSQL +The PostgreSQL extension lets you use PostgreSQL as a metadata store or ingest from a PostgreSQL database. Review Comment: ```suggestion With the PostgreSQL extension, you can use PostgreSQL as a metadata store or ingest from a PostgreSQL database. ``` ########## docs/ingestion/input-sources.md: ########## @@ -833,17 +825,29 @@ For more information on the `maxNumConcurrentSubTasks` field, see [Implementatio ## SQL input source +:::info Required extension +To use the SQL input source, you must load the appropriate extension in your `common.runtime.properties` file. +* To connect to MySQL, load the extension [`mysql-metadata-storage`](../development/extensions-core/mysql.md). +* To connect to PostgreSQL, load the extension [`postgresql-metadata-storage`](../development/extensions-core/postgresql.md). + +The MySQL extension requires a JDBC driver. +For more information, see the [Installing the MySQL connector library](../development/extensions-core/mysql.md). +::: + The SQL input source is used to read data directly from RDBMS. -The SQL input source is _splittable_ and can be used by the [Parallel task](./native-batch.md), where each worker task will read from one SQL query from the list of queries. +The SQL input source is _splittable_ and can be used by the [parallel task](./native-batch.md), where each worker task will read from one SQL query from the list of queries. Review Comment: ```suggestion You can _split_ the ingestion tasks for a SQL input source. When you use the [parallel task](./native-batch.md) indexer?, each worker task reads from one SQL query from the list of queries. ``` Consider rewording for clarity. ########## docs/development/extensions-core/mysql.md: ########## @@ -90,7 +107,7 @@ This extension also supports using MariaDB server, https://mariadb.org/download/ CREATE DATABASE druid DEFAULT CHARACTER SET utf8mb4; -- create a druid user - CREATE USER 'druid'@'localhost' IDENTIFIED BY 'diurd'; + CREATE USER 'druid'@'localhost' IDENTIFIED BY 'druid'; Review Comment: FWIW i think `diurd` is an intentional misspelling for the password. ########## docs/ingestion/input-sources.md: ########## @@ -887,7 +891,7 @@ Compared to the other native batch input sources, SQL input source behaves diffe The Combining input source lets you read data from multiple input sources. It identifies the splits from delegate input sources and uses a worker task to process each split. -Use the Combining input source only if all the delegates are splittable and can be used by the [Parallel task](./native-batch.md). +Use the Combining input source only if all the delegates are splittable and can be used by the [parallel task](./native-batch.md). Review Comment: this reads awkwardly 😬 I know you were just fixing case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
