github-advanced-security[bot] commented on code in PR #17039:
URL: https://github.com/apache/druid/pull/17039#discussion_r1756619520
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/querygen/DruidQueryGenerator.java:
##########
@@ -58,32 +59,58 @@
this.vertexFactory = new PDQVertexFactory(plannerContext, rexBuilder);
}
+ static class DruidNodeStack extends Stack<DruidLogicalNode>
Review Comment:
## No clone method
No clone method, yet implements Cloneable.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7799)
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/querygen/DruidQueryGenerator.java:
##########
@@ -133,6 +161,43 @@
SourceDesc unwrapSourceDesc();
}
+ enum JoinSupportTweaks
+ {
+ NONE,
+ LEFT,
+ RIGHT;
+
+ static JoinSupportTweaks analyze(DruidNodeStack stack)
+ {
+ if (stack.size() < 2) {
+ return NONE;
+ }
+ DruidLogicalNode possibleJoin = stack.get(stack.size() - 2);
+ if (!(possibleJoin instanceof DruidJoin)) {
+ return NONE;
+ }
+ DruidJoin join = (DruidJoin) possibleJoin;
Review Comment:
## Unread local variable
Variable 'DruidJoin join' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7798)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
