Akshat-Jain commented on code in PR #17038:
URL: https://github.com/apache/druid/pull/17038#discussion_r1756665286
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java:
##########
@@ -280,12 +289,21 @@ private static List<OperatorFactory>
computeWindowOperations(
if (!sortMatches(priorSortColumns, sortColumns)) {
// Sort order needs to change. Resort and repartition.
ops.add(new NaiveSortOperatorFactory(new ArrayList<>(sortColumns)));
- ops.add(new
NaivePartitioningOperatorFactory(group.getPartitionColumns()));
+ if (sqlEngine instanceof NativeSqlEngine) {
+ ops.add(new
NaivePartitioningOperatorFactory(group.getPartitionColumns()));
+ } else {
+ ops.add(new
GlueingPartitioningOperatorFactory(group.getPartitionColumns()));
+ }
Review Comment:
> MSQ translation layer part
Can you elaborate which layer do you mean by that?
Do you mean WindowOperatorQueryKit? I originally did that, but it fails the
tests of MSQWindowTest because they also validate the generated MSQ spec, which
still had NaivePartitioningOperatorFactory (as that happens prior to the query
kit layer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
