Akshat-Jain commented on code in PR #17038:
URL: https://github.com/apache/druid/pull/17038#discussion_r1760976017
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java:
##########
@@ -280,12 +289,21 @@ private static List<OperatorFactory>
computeWindowOperations(
if (!sortMatches(priorSortColumns, sortColumns)) {
// Sort order needs to change. Resort and repartition.
ops.add(new NaiveSortOperatorFactory(new ArrayList<>(sortColumns)));
- ops.add(new
NaivePartitioningOperatorFactory(group.getPartitionColumns()));
+ if (sqlEngine instanceof NativeSqlEngine) {
+ ops.add(new
NaivePartitioningOperatorFactory(group.getPartitionColumns()));
+ } else {
+ ops.add(new
GlueingPartitioningOperatorFactory(group.getPartitionColumns()));
+ }
Review Comment:
Based on offline discussion, will pass plannerContext instead of engine to
this method, and will create a separate private method for the duplicate
if-else lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
