kgyrtkirk commented on PR #17078: URL: https://github.com/apache/druid/pull/17078#issuecomment-2355385025
I think the default configs should not set such a thing - unless its really beneficial. I haven't seen any measurements/etc why this was set initially in the commit logs Its mentioned in https://druid.apache.org/docs/latest/operations/basic-cluster-tuning/ ; it seems like it was added as a suggestion in [this PR](https://github.com/apache/druid/pull/7629). I looked at `-XX` flags being set in the files below `examples`: * `-XX:+ExitOnOutOfMemoryError` looks reasonable :) * `-XX:MaxDirectMemorySize` seems okay as well * `-XX:+UseG1GC` (this) I agree that the GC algo selection should be removed - as its important to ship something which works out of the box with the least amount of issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
