funguy-tech commented on code in PR #17083:
URL: https://github.com/apache/druid/pull/17083#discussion_r1766077185
##########
processing/src/main/java/org/apache/druid/utils/CompressionUtils.java:
##########
@@ -657,7 +659,7 @@ public static OutputStream compress(final OutputStream in,
final Format format)
case XZ: return new XZCompressorOutputStream(in);
case SNAPPY: return new FramedSnappyCompressorOutputStream(in);
case ZSTD: return new ZstdCompressorOutputStream(in);
- case ZIP: return new ZipOutputStream(in, StandardCharsets.UTF_8);
+ case ZIP: return new DeflaterOutputStream(in);
Review Comment:
The ZipOutputStream / ZipInputStream expect to take place on entries inside
a ZipEntry. Since these helpers are intended for compressing/decompressing
bytes directly, we instead use the DeflaterOutputStream / InflaterInputStream
underlying compression classes for zip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
