funguy-tech commented on code in PR #17083:
URL: https://github.com/apache/druid/pull/17083#discussion_r1766182394
##########
processing/src/main/java/org/apache/druid/utils/CompressionUtils.java:
##########
@@ -657,7 +659,7 @@ public static OutputStream compress(final OutputStream in,
final Format format)
case XZ: return new XZCompressorOutputStream(in);
case SNAPPY: return new FramedSnappyCompressorOutputStream(in);
case ZSTD: return new ZstdCompressorOutputStream(in);
- case ZIP: return new ZipOutputStream(in, StandardCharsets.UTF_8);
+ case ZIP: return new DeflaterOutputStream(in);
Review Comment:
On second thought, this doesn't make sense as a solution since zip isn't
'just' deflate.
An alternative would be to just use a dummy zipEntry with a single
optimistic getNextEntry on decompress - or, perhaps, to just disable zip as a
valid compression format for Kinesis since it doesn't make much sense in a
record-streaming context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
