Akshat-Jain commented on code in PR #17038:
URL: https://github.com/apache/druid/pull/17038#discussion_r1793854339
##########
processing/src/main/java/org/apache/druid/query/rowsandcols/LazilyDecoratedRowsAndColumns.java:
##########
@@ -95,6 +110,7 @@ public LazilyDecoratedRowsAndColumns(
this.limit = limit;
this.ordering = ordering;
this.viewableColumns = viewableColumns;
+ this.allocatorCapacity = allocatorCapacity != null ? allocatorCapacity :
200 << 20;
Review Comment:
> also make it mandatory; there are just a handfull of callsites. and remove
the new contructor...
Done
> I have a feeling that we will have to pass serialization stuff later; so
exand the integer into a class named like FrameSerializationConfig or
something; and make the this capacity a part of it.
That can be done when/if we need to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
