Akshat-Jain commented on code in PR #17038:
URL: https://github.com/apache/druid/pull/17038#discussion_r1794677447
##########
processing/src/main/java/org/apache/druid/query/operator/NaivePartitioningOperator.java:
##########
@@ -110,28 +79,7 @@ public Closeable goOrContinue(Closeable continuation,
Receiver receiver)
@Override
public Signal push(RowsAndColumns rac)
Review Comment:
Have made local changes to make receiver and the iterator class static. The
code doesn't seem clean though, as I had to pass a bunch of params. Also trying
to see what can be moved to Abstract class with those changes. (This is all on
my local right now, just updating this info here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]