Akshat-Jain commented on code in PR #17038:
URL: https://github.com/apache/druid/pull/17038#discussion_r1803101694
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -66,37 +60,25 @@
import java.util.Collections;
import java.util.List;
import java.util.concurrent.atomic.AtomicInteger;
-import java.util.function.Supplier;
public class WindowOperatorQueryFrameProcessor implements
FrameProcessor<Object>
{
private static final Logger log = new
Logger(WindowOperatorQueryFrameProcessor.class);
- private final WindowOperatorQuery query;
private final List<OperatorFactory> operatorFactoryList;
- private final List<String> partitionColumnNames;
- private final ObjectMapper jsonMapper;
- private final ArrayList<RowsAndColumns> frameRowsAndCols;
private final ArrayList<RowsAndColumns> resultRowAndCols;
+ private final RowsAndColumnsBuilder frameRowsAndColsBuilder;
private final ReadableFrameChannel inputChannel;
private final WritableFrameChannel outputChannel;
private final FrameWriterFactory frameWriterFactory;
private final FrameReader frameReader;
private final int maxRowsMaterialized;
- private Cursor frameCursor = null;
- private Supplier<ResultRow> rowSupplierFromFrameCursor;
- private ResultRow outputRow = null;
private FrameWriter frameWriter = null;
private final VirtualColumns frameWriterVirtualColumns;
private final SettableLongVirtualColumn partitionBoostVirtualColumn;
- // List of type strategies to compare the partition columns across rows.
- // Type strategies are pushed in the same order as column types in
frameReader.signature()
- private final NullableTypeStrategy[] typeStrategies;
-
- private final ArrayList<ResultRow> rowsToProcess;
- private int lastPartitionIndex = -1;
+ private Operator op = null;
Review Comment:
Renamed to `operator`. Any other naming suggestion? 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
