kfaraz commented on PR #17336:
URL: https://github.com/apache/druid/pull/17336#issuecomment-2419158322

   > Segment metadata operations on the coordinator needing to be routed 
through the Overlord is a TODO of this PR. I think it should be simple (but 
tedious) to move the APIs to the Overlord and have an overlord client execute 
these on the coordinator.
   
   It would probably be simpler to write and easier to review if we do this 
part in a separate PR and merge it before the caching changes.
   
   > can continue to perform those operations as DataSegment is immutable.
   
   While this is true for the payload of the segment itself, the schema 
fingerprint may change (typically from null to something non-null. I don't 
think any other change is possible for this column.)
   
   > I hope we can determine the least set of changes to get this working and 
also add a feature flag, if everything else seems good.
   
   The cache should be behind a feature flag.
   
   But to keep things simple, the new Overlord APIs probably don't need to be 
behind the feature flag. During a rolling upgrade, if coordinator gets upgraded 
first and starts calling new APIs on an old Overlord, we can simply give a nice 
error message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to