AmatyaAvadhanula commented on PR #17336: URL: https://github.com/apache/druid/pull/17336#issuecomment-2419176069
> It would probably be simpler to write and easier to review if we do this part in a separate PR and merge it before the caching changes. Thanks. I agree that this would be better. > While this is true for the payload of the segment itself, the schema fingerprint may change (typically from null to something non-null. I don't think any other change is possible for this column.) Segments would be added to the cache during a commit irrespective of whether the CDS feature is enabled. The schema fingerprint backfill that happens on the coordinator doesn't affect the cache and operates on a snapshot that the coordinator uses. Is this understanding incorrect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
