gianm commented on code in PR #17391:
URL: https://github.com/apache/druid/pull/17391#discussion_r1811346027
##########
processing/src/main/java/org/apache/druid/segment/data/ObjectStrategy.java:
##########
@@ -77,6 +78,18 @@ default boolean readRetainsBufferReference()
return true;
}
+ /**
+ * Preferred byte order to read values from a buffer with {@link
#fromByteBuffer(ByteBuffer, int)} and similar methods
Review Comment:
Should also update `fromByteBuffer` contract to say that the caller must
pass in a buffer whose order matches `getByteOrder()`. Please double-check all
callers of `fromByteBuffer` to make sure they do that properly.
##########
processing/src/main/java/org/apache/druid/segment/data/CompressedVariableSizedBlobColumnSupplier.java:
##########
@@ -34,17 +34,29 @@ public class CompressedVariableSizedBlobColumnSupplier
implements Supplier<Compr
public static CompressedVariableSizedBlobColumnSupplier fromByteBuffer(
Review Comment:
This method seems like a bug waiting to happen, where someone _should_
provide both `compressionOrder` and `valueOrder` but only provides
`compressionOrder` because this method exists. Remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
