gianm commented on code in PR #17419:
URL: https://github.com/apache/druid/pull/17419#discussion_r1821246538
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -183,7 +184,7 @@ protected synchronized TaskStatus join(long timeout) throws
IllegalStateExceptio
since Druid doesn't support retrying tasks from a external system
(K8s). We can explore adding a fabric8 watcher
if we decide we need to change this later.
**/
- taskLocation = getTaskLocationFromK8s();
+ taskLocation.set(getTaskLocationFromK8s());
updateState(new State[]{State.NOT_STARTED, State.PENDING},
State.RUNNING);
Review Comment:
I switched them. I'm not sure why the order was this way originally, but it
does make more sense the other way, I think.
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -183,7 +184,7 @@ protected synchronized TaskStatus join(long timeout) throws
IllegalStateExceptio
since Druid doesn't support retrying tasks from a external system
(K8s). We can explore adding a fabric8 watcher
if we decide we need to change this later.
**/
- taskLocation = getTaskLocationFromK8s();
+ taskLocation.set(getTaskLocationFromK8s());
updateState(new State[]{State.NOT_STARTED, State.PENDING},
State.RUNNING);
Review Comment:
I switched them. I'm not sure why the order was this way originally, but it
does make more sense to me the way you're suggesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
