gianm commented on code in PR #17419:
URL: https://github.com/apache/druid/pull/17419#discussion_r1821374777
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -260,11 +261,19 @@ protected TaskLocation getTaskLocation()
since Druid doesn't support retrying tasks from a external system (K8s).
We can explore adding a fabric8 watcher
if we decide we need to change this later.
**/
- if (taskLocation == null) {
+ if (!taskLocation.isDone()) {
log.warn("Unknown task location for [%s]", taskId);
Review Comment:
I think we're deciding to address this through #17417 instead. Most of
what's happening in this PR is about making it so locations are always known by
the time `start()` exits, whereas #17417 is about making that unnecessary by
fetching locations live.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
