AmatyaAvadhanula commented on code in PR #17420:
URL: https://github.com/apache/druid/pull/17420#discussion_r1821493037
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -380,13 +383,11 @@ private boolean processBatch(AllocateRequestBatch
requestBatch)
private Set<DataSegment> retrieveUsedSegments(AllocateRequestKey key)
{
- return new HashSet<>(
- metadataStorage.retrieveUsedSegmentsForInterval(
- key.dataSource,
- key.preferredAllocationInterval,
- Segments.ONLY_VISIBLE
- )
- );
+ return metadataStorage.getSegmentTimelineForAllocation(
Review Comment:
Do you mean when it is false?
If it is true, we are simply getting all the used ids in the retrieval call,
so we'd have to create a SegmentTimeline as we're interested only in the
visible segment set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
