maytasm commented on code in PR #17420:
URL: https://github.com/apache/druid/pull/17420#discussion_r1821480405
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -380,13 +383,11 @@ private boolean processBatch(AllocateRequestBatch
requestBatch)
private Set<DataSegment> retrieveUsedSegments(AllocateRequestKey key)
{
- return new HashSet<>(
- metadataStorage.retrieveUsedSegmentsForInterval(
- key.dataSource,
- key.preferredAllocationInterval,
- Segments.ONLY_VISIBLE
- )
- );
+ return metadataStorage.getSegmentTimelineForAllocation(
Review Comment:
Is it inefficient here if skipSegmentPayloadFetchForAllocation is true? We
are getting segments from retrieveUsedSegmentsForAllocation then creating a
timeline via SegmentTimeline.forSegments and then getting segments back again
via findNonOvershadowedObjectsInInterval. Why do we even need to create a
timeline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
