georgew5656 commented on code in PR #17446:
URL: https://github.com/apache/druid/pull/17446#discussion_r1831620805
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -174,11 +176,13 @@ private void writeTaskPayload(Task task) throws
IOException
* @return
* @throws IllegalStateException
*/
- protected synchronized TaskStatus join(long timeout) throws
IllegalStateException
+ protected synchronized TaskStatus join(long timeout, SettableFuture<Boolean>
taskActiveStatusFuture) throws IllegalStateException
Review Comment:
i guess it would make more sense to maybe split this up into a
joinUntilStart method that calls back into the wait method, i can rewrite it a
bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
