georgew5656 commented on code in PR #17446:
URL: https://github.com/apache/druid/pull/17446#discussion_r1831883883
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -174,11 +176,13 @@ private void writeTaskPayload(Task task) throws
IOException
* @return
* @throws IllegalStateException
*/
- protected synchronized TaskStatus join(long timeout) throws
IllegalStateException
+ protected synchronized TaskStatus join(long timeout, SettableFuture<Boolean>
taskActiveStatusFuture) throws IllegalStateException
Review Comment:
i added a function that just returns a future containing a boolean with info
on whether the task started running successfully. in order to get this to work
i made KubernetesPeonLifecycle a regular argument for KubernetesWorkItem
(instead of setting it with setKubernetesPeonLifecycle afterwards). this seems
fine to me becuase KubernetesPeonLifecycle is just a simple POJO until you call
run or join on it, i don't really see why it needs to be instantiated in doTask
instead of run/joinAsync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
