github-advanced-security[bot] commented on code in PR #17460:
URL: https://github.com/apache/druid/pull/17460#discussion_r1833388289
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandler.java:
##########
@@ -113,16 +134,32 @@
* needed
* @param capabilities The ColumnCapabilities of the dimension
represented by this DimensionHandler
* @param progress ProgressIndicator used by the merging process
+ * @param segmentBaseDir segment write out path; temporary files may
be created here, though should delete
+ * after merge is finished OR be registered
with the Closer parameter
+ * @param closer Closer tied to segment completion. Anything
which is not cleaned up inside of the
+ * merger after merge is complete should be
registered with this closer. For example,
+ * resources which are required for final
serialization of the column
* @return A new DimensionMergerV9 object.
*/
- DimensionMergerV9 makeMerger(
+ default DimensionMergerV9 makeMerger(
String outputName,
IndexSpec indexSpec,
SegmentWriteOutMedium segmentWriteOutMedium,
ColumnCapabilities capabilities,
ProgressIndicator progress,
+ File segmentBaseDir,
Closer closer
- );
+ )
+ {
+ return makeMerger(
+ outputName,
+ indexSpec,
+ segmentWriteOutMedium,
+ capabilities,
+ progress,
+ closer
+ );
Review Comment:
## Deprecated method or constructor invocation
Invoking [DimensionHandler.makeMerger](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8450)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
