clintropolis commented on code in PR #17460:
URL: https://github.com/apache/druid/pull/17460#discussion_r1841055622


##########
processing/src/main/java/org/apache/druid/segment/DimensionHandler.java:
##########
@@ -100,6 +102,25 @@ default MultiValueHandling getMultivalueHandling()
    */
   DimensionIndexer<EncodedType, EncodedKeyComponentType, ActualType> 
makeIndexer(boolean useMaxMemoryEstimates);
 
+  /**
+   * @deprecated use {@link #makeMerger(String, IndexSpec, 
SegmentWriteOutMedium, ColumnCapabilities, ProgressIndicator, File, Closer)}

Review Comment:
   yea, i'll add, though I do plan to remove this shortly after this PR is 
merged, just trying to not be disruptive in the event we do a 31.1 (which i'd 
like to do as mentioned in PR description)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to