Akshat-Jain commented on code in PR #17466: URL: https://github.com/apache/druid/pull/17466#discussion_r1841901631
########## check_test_suite.py: ########## @@ -22,7 +22,7 @@ # this script does some primitive examination of git diff to determine if a test suite needs to be run or not # these jobs should always be run, no matter what -always_run_jobs = ['license checks', '(openjdk8) packaging check', '(openjdk11) packaging check'] +always_run_jobs = ['license checks', '(openjdk11) packaging check'] Review Comment: I'm not sure on this either. But I'd prefer to not mix in Java 17 stuff in this patch - I think it should be a separate work item to go through all CI checks from Java 17 point of view, and decide what we want enabled. Hope that works! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
