clintropolis commented on code in PR #17466:
URL: https://github.com/apache/druid/pull/17466#discussion_r1841991629


##########
.github/workflows/codeql.yml:
##########
@@ -40,7 +40,7 @@ jobs:
     - uses: actions/setup-java@v4
       with:
         distribution: 'zulu'
-        java-version: '8'
+        java-version: '11'

Review Comment:
   i think we should strive to default to the most recent lts version we 
support, we should be deprecating java 11 support soon too tbh, its getting 
quite old too
   
   if we're worried about compiled with java 17 and running on 11 we could add 
make one of the mixed version things configured in this manner?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to