abhishekrb19 opened a new pull request, #17542:
URL: https://github.com/apache/druid/pull/17542

   This PR contains non-functional / refactoring changes of the following 
classes in the `sql` module:
   
   1. Move `ExplainPlan` and `ExplainAttributes` 
from`sql/src/main/java/org/apache/druid/sql/http`  to 
`processing/src/main/java/org/apache/druid/query/explain`
   2. Move `sql/src/main/java/org/apache/druid/sql/SqlTaskStatus.java` -> 
`processing/src/main/java/org/apache/druid/query/http/SqlTaskStatus.java`
   3. Add a new class 
`processing/src/main/java/org/apache/druid/query/http/ClientSqlQuery.java` that 
is effectively a thin POJO version of `SqlQuery` in the `sql` module but 
without any of the Calcite functionality and business logic.
   4. Move `BrokerClient`, `BrokerClientImpl` and `Broker` classes from 
`sql/src/main/java/org/apache/druid/sql/client` to 
`server/src/main/java/org/apache/druid/client/broker`.
   5. Remove `BrokerServiceModule` that provided the `BrokerClient`. The 
functionality is now contained in `ServiceClientModule` in the `server` package 
itself which provides all the clients as well.
   
   This is done so that we can reuse the said classes in 
https://github.com/apache/druid/pull/17353 without brining in Calcite  and 
other dependencies to the Overlord.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to