kfaraz commented on code in PR #17542: URL: https://github.com/apache/druid/pull/17542#discussion_r1872531245
########## sql/src/main/java/org/apache/druid/sql/http/SqlQuery.java: ########## @@ -28,13 +28,17 @@ import org.apache.calcite.avatica.remote.TypedValue; import org.apache.druid.java.util.common.ISE; import org.apache.druid.query.QueryContext; +import org.apache.druid.query.http.ClientSqlQuery; import javax.annotation.Nullable; import java.util.List; import java.util.Map; import java.util.Objects; import java.util.stream.Collectors; +/** + * @see ClientSqlQuery for the equivalent POJO class for use on the client side. + */ public class SqlQuery Review Comment: Could you please mention in the javadoc that the fields `resultFormat` and `parameters` are the ones stopping us from moving this class into processing module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
