github-advanced-security[bot] commented on code in PR #17386:
URL: https://github.com/apache/druid/pull/17386#discussion_r1872622110
##########
processing/src/main/java/org/apache/druid/segment/CursorBuildSpec.java:
##########
@@ -107,14 +113,13 @@
}
/**
- * Any columns which will be used for grouping by a query engine for the
{@link CursorHolder}, useful for
- * specializing the {@link Cursor} or {@link
org.apache.druid.segment.vector.VectorCursor} if any pre-aggregated
- * data is available.
+ * Set of physical columns required from a cursor. If null, and {@link
#groupingColumns} is null or empty and
+ * {@link #aggregators} is null or empty, then a {@link CursorHolder} must
assume that ALL columns are required
*/
@Nullable
- public List<String> getGroupingColumns()
+ public Set<String> getPhysicalColumns()
Review Comment:
## Exposing internal representation
getPhysicalColumns exposes the internal representation stored in field
physicalColumns. The value may be modified [after this call to
getPhysicalColumns](1).
[Show more
details](https://github.com/apache/druid/security/code-scanning/8481)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
