gianm commented on code in PR #17386:
URL: https://github.com/apache/druid/pull/17386#discussion_r1873928291
##########
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndexColumnSelectorFactory.java:
##########
@@ -91,7 +92,14 @@ class IncrementalIndexColumnSelectorFactory implements
ColumnSelectorFactory, Ro
@Override
public ColumnCapabilities getColumnCapabilities(String column)
{
- return capabilitiesMap.get(column);
+ final ColumnCapabilities capabilities = capabilitiesMap.get(column);
+
+ DruidException.conditionalDefensive(
+ cursorBuildSpec.getPhysicalColumns() == null || capabilities !=
null || capabilitiesMap.containsKey(column),
+ "Asked for physical column capabilities for column[%s] which
wasn't specified as required by the query, this is a bug",
Review Comment:
Not necessary to say "this is a bug"; it's implied by the category being
"defensive".
##########
processing/src/main/java/org/apache/druid/segment/UnnestCursorFactory.java:
##########
@@ -97,6 +97,13 @@ public CursorHolder makeCursorHolder(CursorBuildSpec spec)
physicalColumns.add(column);
}
}
+ if (filter != null) {
+ for (String column : filter.getRequiredColumns()) {
+ if (spec.getVirtualColumns().getVirtualColumn(column) == null) {
Review Comment:
nit: could use `!spec.getVirtualColumns().exists(column)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
