kgyrtkirk commented on code in PR #17541:
URL: https://github.com/apache/druid/pull/17541#discussion_r1883696850
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -15585,7 +15587,8 @@ public void
testOrderByAlongWithInternalScanQueryNoDistinct()
JoinType.INNER,
null,
ExprMacroTable.nil(),
- CalciteTests.createJoinableFactoryWrapper()
+ CalciteTests.createJoinableFactoryWrapper(),
+ JoinAlgorithm.BROADCAST
Review Comment:
I don't think there is meaning of this in this context as this engine
doesn't support joinalgorithms ; so this change should be absent here or `null`
?
maybe use `JsonInclude.Include.NON_NULL` and make the class behave like
`null` means `BROADCAST` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
