gianm commented on code in PR #17568:
URL: https://github.com/apache/druid/pull/17568#discussion_r1889132391
##########
processing/src/main/java/org/apache/druid/math/expr/ExpressionProcessingConfig.java:
##########
@@ -39,9 +34,6 @@ public class ExpressionProcessingConfig
"druid.expressions.homogenizeNullMultiValueStringArrays";
public static final String ALLOW_VECTORIZE_FALLBACK =
"druid.expressions.allowVectorizeFallback";
- @JsonProperty("useStrictBooleans")
- private final boolean useStrictBooleans;
Review Comment:
IMO, we should keep the config here, and use it for exactly one thing: to
log a warning on startup if it's set to `false`. Just a little hint for people
that upgrade without reading the release notes, and end up wondering why
behavior changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
