adarshsanjeev commented on code in PR #17550:
URL: https://github.com/apache/druid/pull/17550#discussion_r1904985786
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQSelectTest.java:
##########
@@ -2494,12 +2494,11 @@ public void testJoinUsesDifferentAlgorithm(String
contextName, Map<String, Objec
new QueryDataSource(
newScanQueryBuilder()
.dataSource("foo")
- .virtualColumns(expressionVirtualColumn("v0", "0",
ColumnType.LONG))
- .columns("v0")
+ .columns("__time")
.columnTypes(ColumnType.LONG)
.context(defaultScanQueryContext(
queryContext,
- RowSignature.builder().add("v0",
ColumnType.LONG).build()
+ RowSignature.builder().add("__time",
ColumnType.LONG).build()
Review Comment:
I did not understand why the column name changes here. I don't see any other
change to the test
##########
sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java:
##########
@@ -92,7 +92,8 @@ enum Modes
SORT_REMOVE_CONSTANT_KEYS_CONFLICT(DruidException.class, "not enough
rules"),
REQUIRE_TIME_CONDITION(CannotBuildQueryException.class,
"requireTimeCondition is enabled"),
UNNEST_INLINED(Exception.class, "Missing conversion is Uncollect"),
- UNNEST_RESULT_MISMATCH(AssertionError.class, "(Result count
mismatch|column content mismatch)");
+ UNNEST_RESULT_MISMATCH(AssertionError.class, "(Result count
mismatch|column content mismatch)"),
+ RESULT_MISMATCH_NATIVE_UNNEST_INCORRECT_RESULTS(Throwable.class, "(Result
count mismatch|column content mismatch|ARRAY)");
Review Comment:
Is this required? Won't it be covered by the previous one?
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -6134,9 +6134,8 @@ public void testJoinsWithThreeConditions()
)
);
}
-
+//
Review Comment:
nit: can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
