kfaraz commented on code in PR #17581:
URL: https://github.com/apache/druid/pull/17581#discussion_r1909850476


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -657,6 +658,24 @@ public void run()
                 shouldProcess
             );
 
+            long bytesProcessed = 0;
+            for (ByteEntity entity : record.getData()) {
+              bytesProcessed += entity.getBuffer().remaining();
+            }
+
+            // Emit the processed bytes metric
+            try {
+              toolbox.getEmitter().emit(
+                  ServiceMetricEvent.builder()
+                      .setDimension("taskId", task.getId())
+                      .setDimension("dataSource", task.getDataSource())

Review Comment:
   Yeah, you would need to set that separately. Something like:
   
   ```java
   final ServiceMetricEvent.Builder metricBuilder = new 
ServiceMetricEvent.Builder();
   setTaskDimensions(metricBuilder, task);
   toolbox.getEmitter().emit(metricBuilder.setMetric("segment/txn/failure", 1));
   ```
   
   Using `IndexTaskUtils.setTaskDimensions()` helps avoid duplication of the 
code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to