kfaraz commented on code in PR #17581:
URL: https://github.com/apache/druid/pull/17581#discussion_r1916187941
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -529,6 +532,31 @@ private MSQTaskReportPayload runInternal(final
QueryListener queryListener, fina
countersSnapshot,
null
);
+ // Emit summary metrics
+ emitSummaryMetrics(msqTaskReportPayload, querySpec);
+ return msqTaskReportPayload;
+ }
+
+ private void emitSummaryMetrics(final MSQTaskReportPayload
msqTaskReportPayload, final MSQSpec querySpec)
+ {
+ long totalProcessedBytes = msqTaskReportPayload.getCounters() != null
+ ?
msqTaskReportPayload.getCounters().copyMap().values().stream().mapToLong(
+ integerCounterSnapshotsMap ->
integerCounterSnapshotsMap.values().stream()
+ .mapToLong(counterSnapshots -> {
+ Map<String, QueryCounterSnapshot> workerCounters =
counterSnapshots.getMap();
+ return workerCounters.entrySet().stream().mapToLong(
+ channel -> {
+ if (channel.getKey().startsWith("input")) {
+ ChannelCounters.Snapshot snapshot =
(ChannelCounters.Snapshot) channel.getValue();
+ return snapshot.getBytes() == null ? 0L :
Arrays.stream(snapshot.getBytes()).sum();
+ }
+ return 0L;
+ }).sum();
+ }).sum()).sum()
+ : 0;
Review Comment:
This seems a little difficult to read.
Can we clean up this logic a little? Maybe by returning early when
`msqTaskReportPayload.getCounters()` is null etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
