100pah commented on a change in pull request #11037: new: 10491-support mouse
wheel in slider data zoom
URL:
https://github.com/apache/incubator-echarts/pull/11037#discussion_r322613198
##########
File path: src/component/dataZoom/SliderZoomView.js
##########
@@ -776,6 +779,52 @@ var SliderZoomView = DataZoomView.extend({
});
},
+ /**
+ * Zoom with the mouse wheel
+ * We simply simulate handle zoom
+ * @private
+ */
+ _mouseWheelZoom: function (e) {
+ const STEP_SIZE = 10;
Review comment:
(1) According to the [code
standard](https://echarts.apache.org/en/coding-standard.html),
echarts should use ECMA3 (except ES module).
Could you change the `const` to `var`?
(2) The constant should better be defined in the top of the file (just
personal opinion).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
