pissang commented on a change in pull request #11295: fix bug #7340
URL:
https://github.com/apache/incubator-echarts/pull/11295#discussion_r326954091
##########
File path: src/component/legend/LegendView.js
##########
@@ -481,6 +503,17 @@ export default echarts.extendComponentView({
});
+function setSympleStyle(symbol, symbolType, itemStyle, borderColor,
inactiveBorderColor, isSelected) {
+ if (symbolType !== 'line' && symbolType.indexOf('empty') < 0) {
Review comment:
Thank @100pah for the very detailed review.
I have a different opinion about this part. The `createSymbol` method is
used in many modules. We can't take the risk to update this very basic method
only for a very specific function in legend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
