pissang commented on a change in pull request #11445: fix-11422 关系图边增加forceIgnore属性,不参加节点位置计算 URL: https://github.com/apache/incubator-echarts/pull/11445#discussion_r337319406
########## File path: src/data/Graph.js ########## @@ -137,9 +137,10 @@ graphProto.getNodeById = function (id) { * @param {number|string|module:echarts/data/Graph.Node} n1 * @param {number|string|module:echarts/data/Graph.Node} n2 * @param {number} [dataIndex=-1] + * @param forceIgnore * @return {module:echarts/data/Graph.Edge} */ -graphProto.addEdge = function (n1, n2, dataIndex) { +graphProto.addEdge = function (n1, n2, dataIndex, forceIgnore) { Review comment: The data used in forceHelper is initialized https://github.com/apache/incubator-echarts/blob/master/src/chart/graph/forceLayout.js#L90 There is no need to store this `ignoreFoceLayout` property in the Graph structure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org