pissang commented on a change in pull request #11552: fix(line): overflow
symbols should render if clip is false #11549
URL:
https://github.com/apache/incubator-echarts/pull/11552#discussion_r341889675
##########
File path: src/chart/line/LineView.js
##########
@@ -354,7 +354,7 @@ export default ChartView.extend({
// FIXME step not support polar
var step = !isCoordSysPolar && seriesModel.get('step');
var clipShapeForSymbol;
- if (coordSys && coordSys.getArea) {
+ if (coordSys && coordSys.getArea && seriesModel.get('clip')) {
Review comment:
It's more robust to use `seriesModel.get('clip', true)`.
In this way it won't try get the `clip` property from the root `option` if
it not exists in `series`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
