pissang commented on a change in pull request #11893: fix-11739: apply
continuity line trail for effectline
URL:
https://github.com/apache/incubator-echarts/pull/11893#discussion_r360714884
##########
File path: src/chart/helper/EffectLine.js
##########
@@ -177,6 +177,7 @@ effectLineProto.updateSymbolPosition = function (symbol) {
var cp1 = symbol.__cp1;
var t = symbol.__t;
var pos = symbol.position;
+ var lastPos = Array.from(pos);
Review comment:
Please use `Array.prototype.slice.call(pos)` instead of `Array.from` because
it's not compatible in IE.
Or it can be simply `var lastPos = [pos[0], pos[1]];`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]