alex2wong commented on a change in pull request #11893: fix-11739: apply
continuity line trail for effectline
URL:
https://github.com/apache/incubator-echarts/pull/11893#discussion_r361070337
##########
File path: src/chart/helper/EffectLine.js
##########
@@ -187,7 +188,27 @@ effectLineProto.updateSymbolPosition = function (symbol) {
var ty = quadraticDerivativeAt(p1[1], cp1[1], p2[1], t);
symbol.rotation = -Math.atan2(ty, tx) - Math.PI / 2;
-
+ // enable continuity trail for 'line', 'rect', 'roundRect' symbolType
+ if (this._symbolType === 'line' || this._symbolType === 'rect' ||
this._symbolType === 'roundRect') {
+ if (
+ lastPos[0] !== 0 && lastPos[1] !== 0
+ && lastPos[0] !== p2[0] && lastPos[1] !== p2[1]
Review comment:
that's true, thanks pissang ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
