100pah commented on a change in pull request #11942: Clear all events when
clear() was called #11938
URL:
https://github.com/apache/incubator-echarts/pull/11942#discussion_r361864501
##########
File path: src/echarts.js
##########
@@ -326,6 +326,13 @@ echartsProto._onframe = function () {
}
};
+/**
+ * @return {Object}
+ */
+echartsProto.getHandlers = function () {
+ return this._$handlers;
Review comment:
`this._$handler` is the private property of `Eventful.js`. It should only be
accessible in `Eventful.js` rather than `echarts.js`.
And the method `getHandlers` should not be exposed to developers until
really necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
