pissang commented on a change in pull request #12331: Fix: barBorderRadius
didn't work
URL:
https://github.com/apache/incubator-echarts/pull/12331#discussion_r398713136
##########
File path: src/chart/bar/BarView.js
##########
@@ -673,6 +675,7 @@ function createBackgroundShape(isHorizontalOrRadial,
layout, coord) {
return {
x: isHorizontalOrRadial ? layout.x : coordLayout.x,
y: isHorizontalOrRadial ? coordLayout.y : layout.y,
+ r: isHorizontalOrRadial ? layout.r : coordLayout.r,
width: isHorizontalOrRadial ? layout.width : coordLayout.width,
Review comment:
I think it should be `layout.rb` here. Also coordLayout is a rect. It don't
have r property.
Also, I prefer not to put `radius` in the layout. See comment below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
