susiwen8 commented on a change in pull request #12487:
URL:
https://github.com/apache/incubator-echarts/pull/12487#discussion_r414473109
##########
File path: src/component/axis/CartesianAxisView.js
##########
@@ -137,7 +142,7 @@ var CartesianAxisView = AxisView.extend({
y2: p2[1]
},
style: zrUtil.defaults({
- stroke: lineColors[colorIndex]
+ stroke: (viewLabels && viewLabels[i] &&
!viewLabels[i].formattedLabel ? 'transparent' : lineColors[colorIndex])
Review comment:
I don't think there gonna have side affect, `silent` might concerning
but it has been set to `true`, which won't dispatch event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
