plainheart commented on a change in pull request #124:
URL:
https://github.com/apache/incubator-echarts-doc/pull/124#discussion_r452913892
##########
File path: en/option/component/visual-map-piecewise.md
##########
@@ -215,7 +215,7 @@ When they are not specified, `itemSymbol` is adopted as the
default value (but j
the formatter tool for label.
-+ If it was set as a `string`, it refers to a template, for instance:
`aaaa{value}bbbb{value2}`, where `{value}` and `{value2}` represents the
current seleted range of dataValues.
++ If it was set as a `string`, it refers to a template, for instance:
`aaaa{value}bbbb{value2}`, where `{value}` and `{value2}` represents the
current selected range of dataValues.
Review comment:
> If it was set as a `string`, it refers to a template,
No need to use `was`, use `is` instead.
##########
File path: en/option/series/custom.md
##########
@@ -6,7 +6,7 @@
`custom series` supports customizing graphic elements, and then generate more
types of charts.
-echarts manages the creation, deletion, animation and interaction with other
components (like [dataZoom](~dataZoom)、[visualMap](~visualMap)), which frees
developers from handle those issue themselves.
+echarts manages the creation, deletion, animation and interaction with other
components (like [dataZoom](~dataZoom)、[visualMap](~visualMap)), which frees
developers from handling those issue themselves.
Review comment:
> echarts manages the creation, deletion, animation and...
It's better to use `ECharts` instead of `echarts` and same in the Chinese
documentation.
##########
File path: en/option/series/map.md
##########
@@ -27,7 +27,7 @@ Series of same [map type](~series-map.map) will show in one
map. At this point,
In default case, map series create exclusive `geo` component for themselves.
But `geoIndex` can be used to specify an outer [geo component](~geo), which can
be shared with other series like [pie](~series-pie). Moreover, the region color
of the outer [geo component](~geo) can be controlled by the map series (via
[visualMap](~visualMap)).
-When `geoIndex` specified, [series-map.map](~series-map.map) other style
configurations like [series-map.itemStyle](~series-map.itemStyle) will not
work, but cooresponding configurations in [geo component](~geo) will be used.
+When `geoIndex` specified, [series-map.map](~series-map.map) other style
configurations like [series-map.itemStyle](~series-map.itemStyle) will not
work, but corresponding configurations in [geo component](~geo) will be used.
Review comment:
My opinion about this paragraph is as follows.
1) using **When `geoIndex` is specified** is better.
2) `and` should be inserted before **other style configurations**
##########
File path: en/option/series/map.md
##########
@@ -5,7 +5,7 @@
**Map.**
-Map is maily used in the visulization of geographic area data, which can be
used with [visualMap](~visualMap) component to visualize the datas such as
population distribution density in diffrent areas.
+Map is maimly used in the visualization of geographic area data, which can be
used with [visualMap](~visualMap) component to visualize the datas such as
population distribution density in diffrent areas.
Review comment:
> Map is maimly used in the visualization
mainly -> mainly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
