pissang commented on a change in pull request #12943:
URL:
https://github.com/apache/incubator-echarts/pull/12943#discussion_r454294499
##########
File path: src/coord/radar/RadarModel.ts
##########
@@ -151,11 +151,9 @@ class RadarModel extends ComponentModel<RadarOption>
implements CoordinateSystem
innerIndicatorOpt.name, innerIndicatorOpt
);
}
- const model = zrUtil.extend(
- new Model(innerIndicatorOpt, null, this.ecModel),
- AxisModelCommonMixin.prototype
- ) as AxisBaseModel<InnerIndicatorAxisOption>;
+ mixinAxisModelCommonMethods(Model);
+ const model = new Model(innerIndicatorOpt, null, this.ecModel) as
AxisBaseModel<InnerIndicatorAxisOption>;
Review comment:
Don't mixin the methods to the Model#prototype. It will affect all the
models.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
