Ovilia commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661612213
Excellent job! A small advice on the naming of `order`: may consider `'valueDesc'`, `'valueAsc'`, `'legendDesc'`, `'legendAsc'`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org