pissang commented on a change in pull request #13013:
URL:
https://github.com/apache/incubator-echarts/pull/13013#discussion_r460409283
##########
File path: src/chart/line/LineView.ts
##########
@@ -544,11 +544,18 @@ class LineView extends ChartView {
{
fill: 'none',
stroke: visualColor,
- lineJoin: 'bevel'
+ lineJoin: 'bevel' as CanvasLineJoin
}
));
setStatesStylesFromModel(polyline, seriesModel, 'lineStyle');
+
+ const shouldBolderOnEmphasis = seriesModel.get(['emphasis',
'lineStyle', 'width']) === 'bolder';
+ if (shouldBolderOnEmphasis) {
+ const emphasisLineStyle = polyline.getState('emphasis').style;
+ emphasisLineStyle.lineWidth = lineStyleModel.get('width') + 1;
+ }
Review comment:
I think it's more robust to use `polyline.style.width`. Because it's an
accurate computed value from `lineStyleModel.get('width')`. For example in the
future `lineStyleModel.get('width')` can also be a semantic value
```js
emphasisLineStyle.lineWidth = polyline.style.width + 1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
