pissang commented on a change in pull request #12360:
URL:
https://github.com/apache/incubator-echarts/pull/12360#discussion_r465141997
##########
File path: src/component/toolbox/ToolboxView.js
##########
@@ -147,8 +149,36 @@ export default echarts.extendComponentView({
icons[featureName] = icon;
titles[featureName] = title;
}
+
var iconPaths = featureModel.iconPaths = {};
zrUtil.each(icons, function (iconStr, iconName) {
+ // `tiled` is just for changing stack toggle icon, no need to
add a path.
+ if (isMagicType && iconName === 'tiled') {
+ return;
Review comment:
It's better to put this logic in the `render` and `updateView` method of
`MagicType.js`. ToolboxView should be not aware of what features it may have.
brush feature is a typical example:
https://github.com/apache/incubator-echarts/blob/next/src/component/toolbox/feature/Brush.ts#L47
You may refactor it in the next branch if you wish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
