100pah commented on a change in pull request #12754:
URL:
https://github.com/apache/incubator-echarts/pull/12754#discussion_r437126955
##########
File path: test/funnel.html
##########
@@ -86,9 +86,10 @@
left: 300,
right: 300,
sort: 'ascending',
+ orient: 'horizontal',
Review comment:
We should better add some new test cases for `orient: 'horizontal'`
rather than change the original 'vertical' test cases.
Hint: in echarts source dir,
```shell
npm run mktest funnel2
```
will generate a test caes file `test/funnel2.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
