pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284
@leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot! I add an optimized version that takes a Float64Array as input data. It's a bit more complex to write but has better performance and takes less heap memory. Optimized version: https://echarts-bench-from-uplot.glitch.me/index-optimized.html Original verison: https://echarts-bench-from-uplot.glitch.me/ Tested it on my 15inch mac. The initialization time is about 170ms. And the heap memory is about 10~12MB(peak), 5MB(final). About the smoothing algorithm. I have tried the Catmull-Rom Spline before. But it has similar issues which looks quite weird <img width="1041" alt="infoflow 2020-09-20 15-59-58" src="https://user-images.githubusercontent.com/841551/93706604-69455000-fb5a-11ea-8a0b-0d32d290d2ef.png";> I'm not sure if you did any modification on the Catmull-Rom Spline algorithm. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/841551/93706604-69455000-fb5a-11ea-8a0b-0d32d290d2ef.png"](https://user-images.githubusercontent.com/841551/93706604-69455000-fb5a-11ea-8a0b-0d32d290d2ef.png"){kind=link}